Add TupleHelper and SelectHelper to improve SWIG Go wrapper. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
liuh-80
changed the title
liuh-80
changed the title
qiluo-msft
reviewed
Mar 13, 2024
qiluo-msft
reviewed
Mar 13, 2024
liuh-80
changed the title
qiluo-msft
reviewed
Mar 19, 2024
common/tuplehelper.h
Outdated
| @@ -0,0 +1,28 @@ | |||
| #ifndef __TUPLE_HELPER__ | |||
qiluo-msft
reviewed
Mar 19, 2024
common/tuplehelper.cpp
Outdated
| return kfvOp(tuple); | ||
| } | ||
|
|
||
| std::vector<FieldValueTuple> TupleHelper::getFieldsValues(const KeyOpFieldsValuesTuple& tuple) |
There was a problem hiding this comment.
Fixed, return reference
qiluo-msft
reviewed
Mar 19, 2024
common/tuplehelper.cpp
Outdated
| return fvValue(tuple); | ||
| } | ||
|
|
||
| std::string TupleHelper::getKey(const KeyOpFieldsValuesTuple& tuple) |
There was a problem hiding this comment.
SWIG does not generate wrapper for C++ macro.
We can't change macros to method, because there are code like this:
https://github.com/sonic-net/sonic-swss-common/blob/master/common/json.cpp
kfvKey(cur_db_item) = cur_obj_key;
kfvOp(cur_db_item) = op;
Similer code are in some other projects:
qiluo-msft
reviewed
Mar 19, 2024
| @@ -73,6 +73,27 @@ class Select | |||
| std::set<Selectable *, Select::cmp> m_ready; | |||
| }; | |||
|
|
|||
| class SelectHelper | |||
There was a problem hiding this comment.
We need this new class because SWIG can't handle pointer to pointer parameter:
int Select::select(**Selectable **c,** int timeout = -1, bool interrupt_on_signal = false);
We need this helper class handle the pointer to pointer parameter in C++ code.
qiluo-msft
reviewed
Mar 19, 2024
|
Close because Go wrapper still need improve. the change for GNMI support will create new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
SWIG not support std::tuple, also not support C++ inheritance well, this make go wrapper method of select and pops method does not work.
How I did it
Add TupleHelper and SelectHelper to improve SWIG Go wrapper.
Work item tracking
How to verify it
Pass all test cases.
Add new test case.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add TupleHelper and SelectHelper to improve SWIG Go wrapper.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)