Add swss::Logger to c-api #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks good to me. CI errors seem unrelated. |
common/c-api/logger.cpp
Outdated
| @@ -0,0 +1,29 @@ | |||
| #include <cstring> | |||
There was a problem hiding this comment.
is cstring really needed to be included here?
There was a problem hiding this comment.
Indeed. I removed it. Thanks
There was a problem hiding this comment.
Thanks for the fix, could you sync branch to complete verification as well?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
approved these changes
Feb 6, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
merged since Hua signed off and CI passed. |
r12f
pushed a commit
to sonic-net/sonic-dash-ha
that referenced
this pull request
Mar 7, 2025
### Why SONiC uses config_db to keep logger configuration, which allows changing the configuration on the fly. On the back, swss-common logger subscribes to config_db logger table and notifies the corresponding component. ### What this PR does Hook up to swss-common logger to receive configuration update. In response to the change, dynamically changing log level in rust. This PR can only be committed after sonic-net/sonic-swss-common#969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to hook up to swss::Logger from swbusd/hamgrd in rust, which requires us to add the c-api for logger.
What this PR does
Add c-api for swss::Logger and corresponding unit test