[neighsync] bug: VXLAN EVPN neighbors not in NEIGH_TABLE #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bradh352
changed the title
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 21, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 22, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 23, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
|
@srj102 @dgsudharsan @prsunny mind taking a look at this PR to fix the NEIGH_TABLE entries for EVPN VXLAN? |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 29, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 30, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 31, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 1, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 3, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 4, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 5, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 6, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 7, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 8, 2025
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue sonic-net#3384. The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database: https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors. Signed-off-by: Brad House (@bradh352)
|
@srj102 @dgsudharsan @prsunny ping. This is a fix for a regression. |
|
@LaveenBrcm Could you please check this ? |
prsunny
reviewed
Feb 10, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
VXLAN EVPN learned routes are not entered into NEIGH_TABLE as per Issue #3384.
The EVPN VXLAN HLD specifically states this should be populated so it triggers an update to the SAI database:
https://github.com/sonic-net/SONiC/blob/master/doc/vxlan/EVPN/EVPN_VXLAN_HLD.md#438-mac-ip-route-handling
It appears this was mistakingly introduced in #943 with a short conversation here about the reason, but it didn't take into account other reasons for NOARP entries: https://github.com/sonic-net/sonic-swss/pull/943/files#r332867379
What I did
The reason it was not occurring is NOARP entries were being rejected, this patch adds an exception for externally learned neighbors (which have NOARP set).
How I verified it
Installed on a physical switch and observe remotely learned neighbors are present in NEIGH_TABLE
Details if related
Fixes #3384
Signed-off-by: Brad House (@bradh352)