[swss]: IcmpOrch to support ICMP session offload to NPU #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
changed the title
manamand2020
force-pushed
the
icmporch
branch
from
5b33e27 to
0fb3411
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manamand2020
force-pushed
the
icmporch
branch
from
0fb3411 to
2272aa2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Manas Kumar Mandal <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
IcmpOrch for supporting hardware offloaded ICMP echo sessions.
Changes done here adds support for the SAI ICMP ECHO spec:
https://github.com/opencomputeproject/SAI/blob/master/doc/SAI-Proposal-ICMP-ECHO.md
Why I did it
ICMP echo sessions are used by LinkMgrd to monitor link state in Dual-ToR architecture and switch traffic.
Current software based ICMP echo sessions used by Linkprober in LinkMgrd limits the detection time and uses host network bandwidth.
Hardware based sessions will bring down the detection time and host network bandwidth is not used.
How I verified it
Tested the changes with DVS.
Details if related
ICMP echo table definitions: sonic-net/sonic-swss-common#980
ICMP echo SaiRedis changes: sonic-net/sonic-sairedis#1542