[Fixbug]: Fix delete default HFT configuration issue #4025
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Copilot finished reviewing on behalf of
Pterosaur
November 26, 2025 11:33
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test to verify that a bug related to deleting default HFT (High Frequency Telemetry) configurations has been fixed. The test ensures that TAM_TELEMETRY objects are properly cleaned up from the ASIC database when a default profile with empty object_names and object_counters is deleted.
Key Changes:
- Added
test_hft_empty_default_configtest function to verify proper cleanup of TAM_TELEMETRY objects when deleting a default HFT profile with empty configuration - Test validates that TAM_TELEMETRY objects exist after creation with empty fields and are properly deleted after profile/group removal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ze Gan <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @r12f , could you please help to review this PR? |
r12f
approved these changes
Nov 27, 2025
Contributor
Author
|
Hi @prsunny , could you please help to merge this PR? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DavidZagury
reviewed
Dec 2, 2025
| task_process_status groupTableDel(const std::string &profile_name, const std::string &group_name); | ||
| std::shared_ptr<HFTelProfile> getProfile(const std::string &profile_name); | ||
| std::shared_ptr<HFTelProfile> tryGetProfile(const std::string &profile_name); | ||
| bool isProfileInUse(const std::shared_ptr<HFTelProfile> &profile); |
Contributor
There was a problem hiding this comment.
Not a big issue, but we can mark this as a const function
Suggested change
| bool isProfileInUse(const std::shared_ptr<HFTelProfile> &profile); | |
| bool isProfileInUse(const std::shared_ptr<HFTelProfile> &profile) const; |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ze Gan <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is for fixing a bug that telemetry_tam object may not be deleted after the default HFT profile removed.
Why I did it
To the default profile, its group is empty, so the original checker
isEmptywill be unable to capture the group deletion message.How I verified it
Add a new vstest to cover this scenario.
Details if related