Skip to content
This repository was archived by the owner on Dec 26, 2019. It is now read-only.

Conversation

maladon
Copy link

@maladon maladon commented Aug 31, 2015

Allow incoming date values to be ISO formatted dates that can be parsed automagically by JS.

@soulim
Copy link
Owner

soulim commented Sep 1, 2015

Hey @maladon! Thank you for your help 👍

ISO formatted dates could cause some weird issues because JS converts dates into local time, e.g. you pass 2014-10-17T00:00:00, but depending on your time zone it might be converted into 2014-10-16 (one day behind). You could see more details in #18.

So I would like to know what was the reason for changes in this pull request. Do you have some issues with native JS dates?

@maladon
Copy link
Author

maladon commented Sep 1, 2015

Our back end services all return ISO formatted dates, and since we're not using ember data we just put the response JSON in our models. That means that our "dates" are really just strings in ISO format. This change allows those strings to work with the bootstrap datepicker.

@jelhan
Copy link
Contributor

jelhan commented Nov 18, 2015

@maladon Why don't you use computed properties? Also have a look at #42.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants