Skip to content

fix stepper issues #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

fix stepper issues #1761

merged 3 commits into from
Jun 12, 2025

Conversation

CATISNOTSODIUM
Copy link
Member

Description

Fixing new stepper (tracer) related issues. This includes

  • Primitive math expression does not work in the current stepper.
  • String concatenation visual bug. ("a" + "b" should be "ab", not ab)

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvements

How to test

You can link this package with source academy frontend and test the new stepper playground (refer to this pr source-academy/frontend#3125).

  • Primitive math expression does not work in the current stepper.
    Math-related function calls (e.g. math_sqrt(4)) must not lead to evaluation stuck message if the argument type (number) is correctly specified.
  • String concatenation visual bug. ("a" + "b" should be "ab", not ab)

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jun 12, 2025

Pull Request Test Coverage Report for Build 15602932475

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 77.062%

Totals Coverage Status
Change from base Build 15600110367: 0.01%
Covered Lines: 10100
Relevant Lines: 12737

💛 - Coveralls

@martin-henz martin-henz self-requested a review June 12, 2025 06:09
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit ee06d0c into master Jun 12, 2025
4 checks passed
@martin-henz martin-henz deleted the fix-rewrite-stepper branch June 12, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants