Open SSL v 1.1 support #204 #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra const_cast
using internal::api(EVP_MD_CTX_cleanup(_ctxPtr)); instead of internal::api(EVP_MD_CTX_reset(_ctxPtr));
ghost
reviewed
Dec 24, 2019
| internal::api(EVP_MD_CTX_cleanup(&_ctx)); | ||
| internal::api(EVP_DigestInit(&_ctx, _md)); | ||
| #else | ||
| internal::api(EVP_MD_CTX_cleanup(_ctxPtr)); |
There was a problem hiding this comment.
Suggested change
| internal::api(EVP_MD_CTX_cleanup(_ctxPtr)); | |
| EVP_MD_CTX_free(_ctxPtr); |
For OpenSSL 1.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I tried to build libsourcey with OpenSSL and got errors. Also saw #204 Issue.
i changed some files according to pocoproject/poco@bfaa161 and OpenSSL Documentation.
Please, Check this Pull Request, maybe it will be useful.
i checked local build - build successfull ( OpenSSL 1.1.0 -stable , gcc 6.3. , Debian Stretch )
P.S. Sorry for my English. I'm learning it yet. Thanks.