-
Notifications
You must be signed in to change notification settings - Fork 8
Release #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #18
Conversation
Fix metadata input validation
…ntent is embedded
Allow metadata-json verification without extra source uploads when content is embedded
#14) * Add tracking for external verification * fix requests number and support pending status * Enhance external verification logic and status handling in JobDetails component * Add comment to clarify Etherscan API key usage in requestExternalVerifierStatus * Add ExternalVerifierStatuses component and integrate into JobDetails * Implement maximum amount of retries for ext verifications polling * Enhance countdown in ExternalVerifierStatuses component * Better naming for isJobFullyCompleted * Update explorer link to include code section and rename link text to 'View contract' * Sort external verifiers by label * Add support contract status * Refactor verification and contract status display * Add support for 'already_verified' status in external verifiers * Add expiration status for old verifications * Add external verifier icons * Fix blockscout icon and label style * Styling * Add link in Job Id and contract status titles * Look at payload message for sucess because of Routescan inconsistency --------- Co-authored-by: Kaan Uzdoğan <[email protected]>
✅ Deploy Preview for verify-sourcify-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kuzdogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Just didn't get the problem with pushing to staging
I wanted to open a PR only for my changes, but there were unreleased changes on staging that already went through a review. |
Closes argotorg/sourcify#2433
Unfortunately, another case where pushing to staging wasn't a good idea... There were unreleased changes here, but I wanted a review for my last commit.
Please review the last commit.