Skip to content

Conversation

@manuelwedler
Copy link
Member

Closes argotorg/sourcify#2433

Unfortunately, another case where pushing to staging wasn't a good idea... There were unreleased changes here, but I wanted a review for my last commit.

Please review the last commit.

marcocastignoli and others added 6 commits December 3, 2025 11:47
Allow metadata-json verification without extra source uploads when content is embedded
#14)

* Add tracking for external verification

* fix requests number and support pending status

* Enhance external verification logic and status handling in JobDetails component

* Add comment to clarify Etherscan API key usage in requestExternalVerifierStatus

* Add ExternalVerifierStatuses component and integrate into JobDetails

* Implement maximum amount of retries for ext verifications polling

* Enhance countdown in ExternalVerifierStatuses component

* Better naming for isJobFullyCompleted

* Update explorer link to include code section and rename link text to 'View contract'

* Sort external verifiers by label

* Add support contract status

* Refactor verification and contract status display

* Add support for 'already_verified' status in external verifiers

* Add expiration status for old verifications

* Add external verifier icons

* Fix blockscout icon and label style

* Styling

* Add link in Job Id and contract status titles

* Look at payload message for sucess because of Routescan inconsistency

---------

Co-authored-by: Kaan Uzdoğan <[email protected]>
@netlify
Copy link

netlify bot commented Dec 31, 2025

Deploy Preview for verify-sourcify-ui ready!

Name Link
🔨 Latest commit 3b85ba4
🔍 Latest deploy log https://app.netlify.com/projects/verify-sourcify-ui/deploys/6954fefd34fe1800085b9f59
😎 Deploy Preview https://deploy-preview-18--verify-sourcify-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just didn't get the problem with pushing to staging

@manuelwedler
Copy link
Member Author

lgtm. Just didn't get the problem with pushing to staging

I wanted to open a PR only for my changes, but there were unreleased changes on staging that already went through a review.

@manuelwedler manuelwedler merged commit 4386bea into main Jan 5, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Sprint - Needs Review to Sprint - Done in Sourcify Public Jan 5, 2026
@marcocastignoli marcocastignoli moved this from Sprint - Done to COMPLETED in Sourcify Public Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show link to repo on verify.sourcify.dev/jobs/{job_id} for already_verified errors

4 participants