Skip to content

Commit

Permalink
Additional ChefSpec fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ramereth committed Apr 5, 2020
1 parent 83ccd63 commit 42a53e3
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 12 deletions.
9 changes: 9 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
require 'chefspec'
require 'chefspec/berkshelf'

shared_context 'memcached_stubs' do
before do
stub_command('getent passwd memcached').and_return(false)
stub_command('getent passwd nobody').and_return(false)
stub_command('getent passwd memcache').and_return(false)
stub_command('dpkg -s memcached').and_return(true)
end
end

RSpec.configure do |config|
config.color = true # Use color in STDOUT
config.formatter = :documentation # Use the specified formatter
Expand Down
21 changes: 15 additions & 6 deletions spec/unit/recipes/default_spec.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
require 'spec_helper'

describe 'memcached::default' do
before do
stub_command('getent passwd memcached').and_return(false)
stub_command('getent passwd nobody').and_return(false)
stub_command('getent passwd memcache').and_return(false)
stub_command('dpkg -s memcached').and_return(true)
end
include_context 'memcached_stubs'

context 'on rhel 7' do
platform 'redhat', '7'
Expand All @@ -28,6 +23,13 @@
)
end
it { is_expected.to enable_memcached_instance('memcached') }
it { is_expected.to start_service('memcached') }
it { is_expected.to enable_service('memcached') }
it { is_expected.to_not stop_service('disable default memcached') }
it { is_expected.to_not disable_service('disable default memcached') }
%w(/etc/memcached.conf /etc/sysconfig/memcached /etc/default/memcached).each do |f|
it { is_expected.to delete_file f }
end
it { is_expected.to install_package('memcached').with(version: nil) }
it { expect(chef_run).to create_group('memcached') }
it do
Expand Down Expand Up @@ -106,6 +108,13 @@
)
end
it { is_expected.to enable_memcached_instance('memcached') }
it { is_expected.to start_service('memcached') }
it { is_expected.to enable_service('memcached') }
it { is_expected.to_not stop_service('disable default memcached') }
it { is_expected.to_not disable_service('disable default memcached') }
%w(/etc/memcached.conf /etc/sysconfig/memcached /etc/default/memcached).each do |f|
it { is_expected.to delete_file f }
end
it { is_expected.to install_package('memcached').with(version: nil) }
it { expect(chef_run).to create_group('memcache') }
it do
Expand Down
10 changes: 10 additions & 0 deletions spec/unit/recipes/enable_default_instance_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
require 'spec_helper'

describe 'test::enable_default_instance' do
platform 'ubuntu'
step_into :memcached_instance
include_context 'memcached_stubs'

it { is_expected.to_not stop_service('disable default memcached') }
it { is_expected.to_not disable_service('disable default memcached') }
end
11 changes: 5 additions & 6 deletions spec/unit/recipes/instance_spec.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
require 'spec_helper'

describe 'test::instance' do
before do
stub_command('getent passwd memcached').and_return(false)
stub_command('getent passwd nobody').and_return(false)
stub_command('getent passwd memcache').and_return(false)
stub_command('dpkg -s memcached').and_return(true)
end
include_context 'memcached_stubs'

context 'on rhel 7' do
platform 'redhat', '7'
Expand Down Expand Up @@ -84,6 +79,8 @@
it { is_expected.to enable_memcached_instance('backend_cache') }
it { is_expected.to enable_memcached_instance('painful_cache') }
it { is_expected.to enable_memcached_instance('socket') }
it { is_expected.to stop_service('disable default memcached') }
it { is_expected.to disable_service('disable default memcached') }
it do
is_expected.to create_systemd_unit('memcached_web_cache.service').with(
content:
Expand Down Expand Up @@ -184,6 +181,8 @@
it { is_expected.to enable_memcached_instance('backend_cache') }
it { is_expected.to enable_memcached_instance('painful_cache') }
it { is_expected.to enable_memcached_instance('socket') }
it { is_expected.to stop_service('disable default memcached') }
it { is_expected.to disable_service('disable default memcached') }
it do
is_expected.to create_systemd_unit('memcached_web_cache.service').with(
content:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
memcached_instance 'enable_default_instance' do
disable_default_instance false
end

0 comments on commit 42a53e3

Please sign in to comment.