chore: sync staging with main (export IMAGE_TAG fix) - #7
Merged
Conversation
…r pass (#6) docker compose config --images runs as a separate child process, and a compose file's \${IMAGE_TAG:-...} interpolation only sees variables that are actually in that process's environment. IMAGE_TAG was a plain shell assignment, not exported, so every docker compose invocation in the remote script would silently fall back to the compose file's default (<env>-latest) instead of the immutable per-commit tag -- meaning the guard that verifies the pin would never match, and had it ever been bypassed, an actual deploy would pull/run the wrong, mutable image instead of the pinned commit. Verified empirically: a minimal compose file with \${IMAGE_TAG:-x} resolves to the default when IMAGE_TAG is a plain assignment in the calling shell, and resolves correctly once exported. Caught by a security-reviewer pass requested before editing the live VPS compose file, ahead of any real cutover attempt. Co-authored-by: Christian Rubio <christianrubioortiz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-forward sync: brings the export-IMAGE_TAG fix (#6) into staging before the next dispatch.