Fixed resolution, removed borders, changed colors#3687
Open
Xedextro wants to merge 1 commit intosp614x:masterfrom
Open
Fixed resolution, removed borders, changed colors#3687Xedextro wants to merge 1 commit intosp614x:masterfrom
Xedextro wants to merge 1 commit intosp614x:masterfrom
Conversation
The previous skybox.png was 770x514 pixels, which is not a multiple of 768x512. This version additionally removes the black borders present and instead distinctly colors each face. The text on each face (top/north/etc, including "N" marker on top and bottom) and sub-horizon shading have been preserved.
Contributor
|
You should mention "skybox" in the title, otherwise it can be assumed you changed multiple files. |
Collaborator
|
Bump, this should legitimately be considered (or contested with reason), even if over 2 years old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous skybox.png was 770x514 pixels, which is not a multiple of 768x512. This version additionally removes the black borders present and instead distinctly colors each face. The text on each face (top/north/etc, including "N" marker on top and bottom) and sub-horizon shading have been preserved.
The noticeably smaller file size is due to the use of 4-bit color depth rather than the 32-bit used by the previous version.