Добавление шкафа с логотипом фонда#1044
Conversation
|
Warning Review limit reached
More reviews will be available in 31 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughPR добавляет две новые сущности хранилища для SCP-объектов: ChangesSCP Storage Entities Addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/_Scp/Entities/Structures/Storage/Closets/closets.yml`:
- Around line 112-119: The prototype entity ScpClosetLogotype is missing the
required English fallback fields; add top-level YAML keys name and description
for this entity (alongside the existing id/parent/components) so toolshed/editor
tooling can use them; update the ScpClosetLogotype block (the entity with
components EntityStorageVisuals and states
stateBaseClosed/stateDoorOpen/stateDoorClosed) to include explicit name: "..."
and description: "..." entries in English matching the pattern used by other
entities in this file.
In
`@Resources/Prototypes/_Scp/Entities/Structures/Storage/Closets/Lockers/lockers.yml`:
- Around line 547-554: The prototype ScpLockerLogotype (parent ScpLockerBase,
component EntityStorageVisuals) is missing the required English fallback fields
name and description; add top-level name and description keys with English text
directly into the YAML for ScpLockerLogotype (alongside existing FTL
localization entries) so toolshed/editor tooling can read them — ensure they are
simple string values (e.g., name: "SCP Locker" and description: "Standard SCP
locker") placed inside the ScpLockerLogotype mapping.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1912c06c-66fe-45d3-8f30-0a14203f6eb4
⛔ Files ignored due to path filters (4)
Resources/Textures/_Scp/Structures/Storage/closet.rsi/scp.pngis excluded by!**/*.pngResources/Textures/_Scp/Structures/Storage/closet.rsi/scp_door.pngis excluded by!**/*.pngResources/Textures/_Scp/Structures/Storage/closet.rsi/scp_icon.pngis excluded by!**/*.pngResources/Textures/_Scp/Structures/Storage/closet.rsi/scp_open.pngis excluded by!**/*.png
📒 Files selected for processing (7)
Resources/Locale/en-US/_prototypes/_scp/entities/structures/storage/closets/closets.ftlResources/Locale/en-US/_prototypes/_scp/entities/structures/storage/closets/lockers/lockers.ftlResources/Locale/ru-RU/_prototypes/_scp/entities/structures/storage/closets/closets.ftlResources/Locale/ru-RU/_prototypes/_scp/entities/structures/storage/closets/lockers/lockers.ftlResources/Prototypes/_Scp/Entities/Structures/Storage/Closets/Lockers/lockers.ymlResources/Prototypes/_Scp/Entities/Structures/Storage/Closets/closets.ymlResources/Textures/_Scp/Structures/Storage/closet.rsi/meta.json
|
@MorDast1 это пипец. Ты посматривай какие спрайты проходят, хорошо? Потому что это ну вообще прям, отборнейшее |
ачо тут не так |
|
@666XxttimurkaxX666 |
666XxttimurkaxX666
force-pushed
the
add-scp-lockers
branch
from
397a25d to
28e6352
Compare
3 participants
Краткое описание | Short description
ну типо шкаф лол
Ссылка на багрепорт/Предложение | Related Issue/Bug Report
Медиа (Видео/Скриншоты) | Media (Video/Screenshots)
Changelog
🆑 timur
Summary by CodeRabbit
Новые возможности