Возможность сломать и починить пандору#1045
Conversation
|
Warning Review limit reached
More reviews will be available in 31 minutes and 45 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughИзменения добавляют механику разрушения контейнера SCP-173: при критическом уроне контейнер разламывается на двери и поломанную часть, которые затем можно восстановить через последовательность якорения и сварки. Добавлены соответствующие локализационные строки, спрайт-состояния и системные теги. ChangesSCP-173 Cage damage and reconstruction
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Suggested labels
Suggested reviewers
Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 errors)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Prototypes/_Scp/Entities/Objects/Misc/scp_cage.yml (1)
61-95:⚠️ Potential issue | 🟠 MajorПорог разрушения
500вscp_cage.yml: проверьте, что он применяется только к сценариям Pandora и корректно выполняет спавн
- Утечки на другие клетки через наследование не видно: изменение
resistTimeи базовогоDestructibleживёт в цепочкеCrateScpCage*и не должно затрагивать прочие_Scpварианты.- В
CrateScpCageиCrateScpCageScp173используетсяDestructible.thresholdsсdamage: 500, но с разной логикой (DoActsBehaviorvsSpawnEntitiesBehavior+ последующийDestruction) — при конфликте/порядке срабатыванийSpawnEntitiesBehaviorможет не успеть отработать; приведите логику к одному порогу/поведению или явно гарантируйте нужный порядок.CrateScpCageDoor173иCrateScpBrokenCage173в YAML не содержат fallbackname/description(EN), из‑за чего нарушаются требования к localization-strings; добавьте соответствующие английские fallback значения в YAML.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/_Scp/Entities/Objects/Misc/scp_cage.yml` around lines 61 - 95, The Destructible.thresholds damage: 500 entry must be scoped/normalized so spawning always runs before final destruction: update CrateScpCage and CrateScpCageScp173 to either (A) consolidate into a single Destructible.thresholds entry that lists SpawnEntitiesBehavior followed by Destruction/DoActsBehavior in that order, or (B) explicitly guarantee execution order (place SpawnEntitiesBehavior in the same threshold above DoActsBehavior or use an explicit ordering flag if available) so SpawnEntitiesBehavior completes before the Destruction behavior; ensure this 500 threshold only applies to Pandora scenarios (guard it with the same conditional/tag used for Pandora variants) and confirm the resistTime change remains scoped via the CrateScpCage* inheritance chain. Also add English fallback name and description entries for CrateScpCageDoor173 and CrateScpBrokenCage173 in the YAML to satisfy localization-strings requirements.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Locale/en-US/_prototypes/_scp/entities/objects/misc/scp_cage.ftl`:
- Line 12: Update the .desc value in scp_cage.ftl to replace the awkward phrase
"without gate" with a natural English variant (prefer "without its gate" or
"without a gate"); specifically edit the .desc entry for the SCP cage entity to
read e.g. "The Pandora hangar without its gate. To fix it, you need to put the
door on its hinges, tighten them with a wrench, and then weld it." and ensure
the change follows the ss14-localization-strings quality expectations for
player-facing text.
In `@Resources/Locale/en-US/_strings/_scp/scp/scp173.ftl`:
- Line 4: The string key scp-cage-door-insert currently reads "gates of the
\"Pandora\"" (plural) but the gameplay step and ru-RU translation refer to
inserting a single door; update the en-US value to a singular form that matches
the action (e.g., change to "gate of the \"Pandora\"" or similar singular
phrasing) so the scp-cage-door-insert locale entry aligns with gameplay and
other locales.
In `@Resources/Locale/ru-RU/_prototypes/_scp/entities/objects/misc/scp_cage.ftl`:
- Line 12: Fix the typo in the localization entry for the SCP cage description:
update the .desc string that currently contains "петели" to the correct word
"петли" so the repair instruction reads "поставить дверь на петли, прикрутить их
гаечным ключом и использовать сварку"; ensure only the word is changed in the
.desc value to comply with ss14-localization-strings rules.
In `@Resources/Prototypes/_Scp/Entities/Objects/Misc/scp_cage.yml`:
- Around line 161-200: Add English fallback localization fields to the two new
prototypes so editor/Toolshed have defaults: for entities CrateScpCageDoor173
and CrateScpBrokenCage173 add explicit YAML keys name and description (and
suffix if applicable by project convention) with English text directly in the
prototype block (in addition to any FTL keys), e.g. simple descriptive English
strings that match the entity purpose; ensure the fields are placed alongside
existing keys in each entity YAML entry.
---
Outside diff comments:
In `@Resources/Prototypes/_Scp/Entities/Objects/Misc/scp_cage.yml`:
- Around line 61-95: The Destructible.thresholds damage: 500 entry must be
scoped/normalized so spawning always runs before final destruction: update
CrateScpCage and CrateScpCageScp173 to either (A) consolidate into a single
Destructible.thresholds entry that lists SpawnEntitiesBehavior followed by
Destruction/DoActsBehavior in that order, or (B) explicitly guarantee execution
order (place SpawnEntitiesBehavior in the same threshold above DoActsBehavior or
use an explicit ordering flag if available) so SpawnEntitiesBehavior completes
before the Destruction behavior; ensure this 500 threshold only applies to
Pandora scenarios (guard it with the same conditional/tag used for Pandora
variants) and confirm the resistTime change remains scoped via the CrateScpCage*
inheritance chain. Also add English fallback name and description entries for
CrateScpCageDoor173 and CrateScpBrokenCage173 in the YAML to satisfy
localization-strings requirements.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 05779872-dda5-4295-bbe2-c302d3c74a9f
⛔ Files ignored due to path filters (1)
Resources/Textures/_Scp/Objects/Misc/scp_cage.rsi/door.pngis excluded by!**/*.png
📒 Files selected for processing (7)
Resources/Locale/en-US/_prototypes/_scp/entities/objects/misc/scp_cage.ftlResources/Locale/en-US/_strings/_scp/scp/scp173.ftlResources/Locale/ru-RU/_prototypes/_scp/entities/objects/misc/scp_cage.ftlResources/Locale/ru-RU/_strings/_scp/scp/scp173.ftlResources/Prototypes/_Scp/Entities/Objects/Misc/scp_cage.ymlResources/Prototypes/_Scp/tags.ymlResources/Textures/_Scp/Objects/Misc/scp_cage.rsi/meta.json
|
Сделай сломанную Пандору как конструкцию, дабы в осмотре показывало, что нужно сделать далее |
А так же выясни, почему происходит такая ошибка
|
оно и так это делает |
это никак не связанно с моим пром |
|
оно происходит вообще рандомно и без разницы от чего |
|
типо я видел эту ошибку даже тогда когда просто брал в руки 999 или швабру в две руки |
Оно просто спавнит сломанную пандору, в осмотре которой не пишет, что нужно ткнуть гаечным или дверкой, ты это вписал в описании. Сделай это как реализовано в тех-же постройках консолей и т.п. |
666XxttimurkaxX666
force-pushed
the
tweak-scp-173
branch
from
bc22587 to
5245079
Compare
|
|
Возьмите спрайты с канала спрайтеров. Там есть и двери и сломанная пандора. Дрд запрашивал спрайты несколько месяцев назад |
Вот такие |
у меня нет доступа к каналам спрайтеров |
3 participants
Краткое описание | Short description
теперь при получении 500 урона у пандоры выбьются ворота
чтобы ее починить нужно вставить ворота на место, закрутить их гаечным ключом и сварить
Ссылка на багрепорт/Предложение | Related Issue/Bug Report
Медиа (Видео/Скриншоты) | Media (Video/Screenshots)
Changelog
🆑 timur
Summary by CodeRabbit
New Features
Bug Fixes
Documentation