Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15: Add linked_spaces, country_code, hint and areas #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rnestler
Copy link
Member

@rnestler rnestler commented May 5, 2024

See #117

Checklist

  • Tests added if applicable
  • README updated if applicable
  • CHANGELOG updated if applicable
  • If a commit includes a breaking change, include the string [breaking-change] somewhere in the commit message

@rnestler rnestler force-pushed the add-v15-support branch from 7058265 to e9db2b2 Compare May 5, 2024 20:05
@rnestler rnestler self-assigned this May 20, 2024
@rnestler rnestler marked this pull request as ready for review November 10, 2024 22:14
@rnestler rnestler requested a review from dbrgn November 10, 2024 22:14
@dbrgn
Copy link
Collaborator

dbrgn commented Nov 10, 2024

@rnestler you requested a review, but there are many open questions, primarily regarding the version support. We currently have logic in the builder related to the desired target version. This hasn't yet been updated to v15 (i.e. we have new fields, but the API claims that it generates v14)... Also, we need to decide how to handle mixed support.

A good option would probably be to drop support for all but the latest and second-to-latest version. That would mean that we'd support v14 and v15 (but not v0.13). Supporting all three would work as well, but would mean that we'd need to add a lot more validation logic. In that case, we'd avoid complicated questions related to mixed mode etc.

Before we continue, we should probably merge #122, then rebase and merge #121, because that will allow us to implement the optional location more easily.

@rnestler
Copy link
Member Author

Yeah I just wanted to make you aware of the PR. The open questions are in the ticket #117 as well.

@rnestler rnestler changed the title Add v15 support v15: Add linked_spaces, country_code, hint and areas Dec 29, 2024
@rnestler rnestler mentioned this pull request Dec 29, 2024
13 tasks
@rnestler
Copy link
Member Author

Can we go ahead and merge the PR's that just add new v15 fields and then start working on the new multi-version handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants