Fix Inventree tests and wait for official digikey-api release #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@eeintech I was thinking if it would make sense to make the digikey plugin source code local or to use the git subrepository function to get it working with pip again. Because I don't see the plugin being officially updated or that someone takes it over from the initial developer anytime soon. |
Collaborator
Author
|
@T0jan I saw the maintainer slowly merging PRs at the end of the year last year so I was hopeful but yeah maybe you're right... |
Collaborator
Author
|
@T0jan Do you have any free time to pull the full package here and remove (probably better to comment) dependencies? |
Collaborator
|
@eeintech limited time rn, I will let you know if I find some time to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.2.0can't be uploaded to PyPI because of this error: https://github.com/sparkmicro/Ki-nTree/actions/runs/12538420052/job/34963596376