Skip to content

Rename nvmf rdma #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tomzawadzki
Copy link
Contributor

Just small renames to match scheme from other workflows. Only functional change is pattern for pulling artifacts from all workflows, that will now include nvmf-phy job.

The pattern so far seems to be shaping up 'who-job-type-of-test-what-enviroment-autotest', ex:

common-job-nvmf-tcp-vm-autotest
common-job-release-build-gcc-container-autotest
hpe-job-nvmf-rdma-phy-autotest

phy-autotest is used due to real hardware being under test, in contrast to emulated devices. Even if the execution environment is a VM with passed VFs.

This is just copy-paste from spdk-common-tests.yml.

Signed-off-by: Tomasz Zawadzki <[email protected]>
Just small renames to match scheme from other workflows.
Only functional change is pattern for pulling artifacts
from all workflows, that will now include nvmf-phy job.

The pattern so far seems to be shaping up
'who-job-type-of-test-what-enviroment-autotest', ex:
common-job-nvmf-tcp-vm-autotest
common-job-release-build-gcc-container-autotest
hpe-job-nvmf-rdma-phy-autotest

Signed-off-by: Tomasz Zawadzki <[email protected]>
@tomzawadzki tomzawadzki requested a review from mhae April 2, 2025 13:54
Copy link
Contributor

@mhae mhae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That was bugging me as well.

Copy link
Contributor

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is autotest at the end add anything useful ? can we remove it across all ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants