Set permissions: contents: read at workflow top level #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from set the write permission at job level, we have to set the read permission at the top level as well. Signed-off-by: Arthit Suriyawongkul <[email protected]>
bact
added
security
github_actions
|
This one works. We got 10 points now for this category. Yay. (I feel I got gamified by OpenSSF) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #245 improves the OpenSSF Scorecard from 7.5 to 8.1 but we probably can do better in the Token-Permission category (currently got 7).
Apart from set the write permission at job level, we have to set the read permission at the top level as well, as suggested in Remediation section of the code scanning report.