Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put OSV-Scanner config files to the scanned file’s directory #255

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

bact
Copy link
Collaborator

@bact bact commented Jan 31, 2025

I have reread the documentation carefully again, looks like we have to put the osv-scanner.toml in the scanned file's directory -- I think it is the specific level of the file that has an issue. So I will try this again.

--

"To configure scanning, place an osv-scanner.toml file in the scanned file’s directory."
https://google.github.io/osv-scanner/configuration/

"To configure scanning, place an osv-scanner.toml file in the scanned file’s directory."

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the security label Jan 31, 2025
@bact
Copy link
Collaborator Author

bact commented Jan 31, 2025

@jspeed-meyers hope you are not really tired with this. I hope this can be our last PR on this thing. (If not, I will pause on this for at least a week.)

Copy link
Collaborator

@jspeed-meyers jspeed-meyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's okay. I'm worried about YOU being tired of this, not me :) I'm just reviewing and approving PRs. Thank you!

@jspeed-meyers jspeed-meyers merged commit 73cd129 into spdx:main Jan 31, 2025
6 checks passed
@bact bact deleted the osv-scanner-config-at-vuln-file-dir branch January 31, 2025 16:41
@bact
Copy link
Collaborator Author

bact commented Jan 31, 2025

We have done it!

Now we've got full 10 points for the Vulnerabilities category.

@jspeed-meyers
Copy link
Collaborator

Nice job! yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants