Skip to content

Add elementwise tests #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2023
Merged

Add elementwise tests #10

merged 1 commit into from
Jul 16, 2023

Conversation

Phlosioneer
Copy link
Contributor

Adds:

  • contains for both elements and ranges
  • max and min
  • is_subset and is_superset

Partially addresses #9

I tried to match the unconventional rust formatting, please let me know if you want me to change anything.

@Phlosioneer
Add elementwise tests
5e39613 
Adds:
- contains for both elements and ranges
- max and min
- is_subset and is_superset

Partially addresses spearman#9
@spearman spearman merged commit 5e39613 into spearman:master Jul 16, 2023
@spearman spearman mentioned this pull request Jul 16, 2023
Open
@spearman
Copy link
Owner

Thanks, I refactored is_subset to use the all iterator adapter

range-set/src/lib.rs

Line 289 in 147a22e

self.ranges.iter().all(|range| other.contains_range_ref (range))

@Phlosioneer
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phlosioneer @spearman