Skip to content

Move notifications app under backend/notifications/ #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2025
Merged

Conversation

pashiav
Copy link
Contributor

@pashiav pashiav commented Jun 18, 2025

Fixes #6707

This PR reorganizes the project structure by moving the notifications app into a new backend/notifications/ directory under specifyweb/.

Summary of Changes:

  • Moved notifications to specifyweb/backend/notifications/
  • Updated all import paths to reflect the new location
  • Updated SPECIFY_APPS in settings.py to include specifyweb.backend.notifications

This is the 6th PR in a broader backend reorganization. No frontend behavior or functionality was changed.

Notes:

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Please cross check the following functionalities with main.

  • General Notifications testing

    Note that notifications may take a moment to pop up. Verify that you can:

    Record Merging (Documentation):

    • Query on the Agent table
    • Select 2 records -> Click on Merge Records
    • Merge those records
    • Receive a notification that the merge process has started
    • Receive a notification that the merge process has succeeded

    Queries (Note: Exported CSV files from queries do not always notify the user #4566):

    Screenshot 2025-06-18 at 3 30 59 PM
    • Click Create a CSV or Create KML
    • Receive a notification containing the CSV/KML when completed

    Other:

    • Clicking Clear All removes all notifications.
      - Note: This button shows up when there is more than 1 notification

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jun 18, 2025
@pashiav pashiav added this to the 7.12.0 milestone Jun 18, 2025
@pashiav pashiav self-assigned this Jun 18, 2025
@pashiav pashiav linked an issue Jun 18, 2025 that may be closed by this pull request
@pashiav pashiav marked this pull request as ready for review June 18, 2025 20:50
@pashiav pashiav requested review from CarolineDenis and a team June 18, 2025 20:50
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[X] General Notifications testing
- [X] Receive a notification that the merge process has started
- [X] Receive a notification that the merge process has succeeded
- [X] Receive a notification containing the CSV/KML when completed
- [X] Clicking Clear All removes all notifications.

Works as expected!

@pashiav pashiav requested a review from a team July 2, 2025 18:16
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • General Notifications testing
    • Receive a notification that the merge process has started
    • Receive a notification that the merge process has succeeded
    • Receive a notification containing the CSV/KML when completed
    • Clicking Clear All removes all notifications.

Looks good

Base automatically changed from issue-6705 to issue-6571 July 16, 2025 20:52
@pashiav pashiav merged commit 5f1d734 into issue-6571 Jul 16, 2025
14 checks passed
@pashiav pashiav deleted the issue-6707 branch July 16, 2025 20:53
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reorganize notifications app under backend/notifications/
4 participants