-
Notifications
You must be signed in to change notification settings - Fork 37
Add Series Entry to Collection Objects #6710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Triggered by df184bd on branch refs/heads/issue-6276
TODO:
|
Make range start readonly Combine with Bulk Carry Forward
Fix carrying forward after error occurs
Triggered by 2f592f8 on branch refs/heads/issue-6276
Separate Bulk Carry Dialog
Triggered by e681fa5 on branch refs/heads/issue-6276
Triggered by 5e89f54 on branch refs/heads/issue-6276
Disable Carry Forward when no auto increment Add canAutoIncrement method to formatters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Carry Forward range input should appear
- Make sure you can only enter a valid start catalog number (It should use the catalog num of the CO you just saved)
- Make sure you can only enter a valid end catalog number
- Make sure you can't enter invalid ranges (where the start is bigger than the end for example)
- Click Carry Forward and make sure all the COs in the range you specified were created
- Click Carry Forward and see a dialog with a list of all existing catalog numbers.
- Try Bulk Carry Forward and make sure no record set is created. But make sure all newly created records appear on the form page thing.
Works as expected!
I fixed an issue with the catalog number formatter not being used if you are using one that has a custom title for it. I added the following check to the instructions to test formatters:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not work on DBs with multiple collections (ojsmnh in the fossil inverts collection), but worked fine on a db with only one collection (kubirds). On a a DB with multiple collections it claims that the numbers are already being used when they do not exist, this is likely because the numbers do exist in another collection.
07-02_09.10.mp4
Increase record limit to 500
@emenslin I think I have a fix for that, pushed it 👍👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Carry Forward range input should appear
- Make sure you can only enter a valid start catalog number (It should use the catalog num of the CO you just saved)
- Make sure you can only enter a valid end catalog number
- Make sure you can't enter invalid ranges (where the start is bigger than the end for example)
- Click Carry Forward and make sure all the COs in the range you specified were created
- Click Carry Forward and see a dialog with a list of all existing catalog numbers.
- Try Bulk Carry Forward and make sure no record set is created. But make sure all newly created records appear on the form page thing.
- Try creating a CO with a Collection Object Type with that uses a different formatter for the catalog number. Bulk Carry should still work, except if the formatter does not support autoincrementing (the button will be disabled).
I think if someone tries to carry forward over the range limit then it should just be blocked instead of throwing an error (something similar to the dialog when you try to carry forward over a number that already exists). With the current behavior the error also forces the user to go to the home screen which is not ideal.
07-03_14.41.mp4
Refactor BulkCarryRange error dialog
Triggered by 5f64c9a on branch refs/heads/issue-6276
@emenslin I added a better dialog 👍 And if an error occurs for whatever reason you should be able to dismiss it now! I did have to refactor parts of the code, so I could've broken some things. From my testing everything still seems to work, but you'll probably want to double check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Carry Forward range input should appear
- Make sure you can only enter a valid start catalog number (It should use the catalog num of the CO you just saved)
- Make sure you can only enter a valid end catalog number
- Make sure you can't enter invalid ranges (where the start is bigger than the end for example)
- Click Carry Forward and make sure all the COs in the range you specified were created
- Click Carry Forward and see a dialog with a list of all existing catalog numbers.
- Try Bulk Carry Forward and make sure no record set is created. But make sure all newly created records appear on the form page thing.
- Try creating a CO with a Collection Object Type with that uses a different formatter for the catalog number. Bulk Carry should still work, except if the formatter does not support autoincrementing (the button will be disabled).
Looks good, I did not run into any errors!
Triggered by d822d6a on branch refs/heads/issue-6276
Fixes #6276
Adds Bulk Carry Forward Range preference to Collection Objects.
Checklist
self-explanatory (or properly documented)
Testing instructions