-
Notifications
You must be signed in to change notification settings - Fork 37
Move businessrules
app under backend/businessrules
#6778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue-6769
Are you sure you want to change the base?
Conversation
businessrules
under backend/businessrules
businessrules
app under backend/businessrules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[X] General Business Rules testing
- [X] Verify that save is blocked and a Field is required. points to a required empty field
- [X] Ensure that save blockers work the same as main
on other tables (e.g. Taxon, Collection Object)
- [X] Verify that the rule is respected and behavior is identical to main
Works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- General Business Rules testing (additional gen testing in addition to the ones below)
-
Verify that save is blocked and a Field is required. points to a required empty field
-
Ensure that save blockers work the same as
main
on other tables (e.g. Taxon, Collection Object) -
Verify that the rule is respected and behavior is identical to
main
-
Issues:
- If you add accession agents but don't fill out the fields you can't save but the save button also doesn't turn red. This happens in seemingly all other forms if you don't fill out the required field the field turns red but the save button stays orange.
Issue branch:
07-03_10.21.mp4
Main:
07-03_10.22.mp4
- Similarly there is also no save blocker if you uncheck 'is current' under determination on the CO form so you can save without a current determination.
Issue branch:
07-03_10.28.mp4
Main:
07-03_10.29.mp4
- There is an issue with uniqueness rules where sometimes you can save an invalid form (possibly related to #4800 but does not happen in main) also could be related to the save blocker issues I mentioned above.
Issue branch:
07-03_10.36.mp4
Crash report: Specify 7 Crash Report - 2025-07-03T15_36_57.593Z.txt
Main:
07-03_10.37.mp4
@emenslin thanks for your review! All issues should be fixed now - please try it out again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- General Business Rules testing (additional gen testing in addition to the ones below)
- Verify that save is blocked and a Field is required. points to a required empty field
- Ensure that save blockers work the same as
main
on other tables (e.g. Taxon, Collection Object) - Verify that the rule is respected and behavior is identical to
main
Looks good, all behavior seems to be identical to main
Fixes #6777
This PR reorganizes the project structure by moving the
businessrules
app into a newbackend/businessrules/
directory underspecifyweb/
.Summary of Changes:
businessrules
tospecifyweb/backend/businessrules/
SPECIFY_APPS
insettings.py
to includespecifyweb.backend.businessrules
This is the 13th PR in a broader backend reorganization. No frontend behavior or functionality was changed.
Notes:
export
app underbackend/export
#6770.Checklist
self-explanatory (or properly documented)
Testing instructions
Relevant Documentation: Uniqueness Rules & Business Rules
Please cross check the following functionalities with
main
:General Business Rules testing (additional gen testing in addition to the ones below)
main
on other tables (e.g. Taxon, Collection Object)main