Migrate `Rank.Threshold` to User Preferences #6844

grantfitzsimmons · 2025-07-01T01:57:51Z

This PR removes the dependence on the TreeEditor.Rank.Threshold remote preference in favor of using the User Preferences system.

This does not migrate the existing value for this field, and it will instead need to be updated manually to reflect the collection's preference. The default value for all trees is to show the count of all nodes, but this might be undesirable.

ThresholdOptions.mov

Testing Instructions

Go to User Preferences
Verify that under each tree there is an option to configure the "Show object count"'
Verify that the ranks returned are correct for the current collection's tree(s)
Select a rank from each tree
Verify that the counts for all nodes under that level are shown in the tree
Test this across all current trees and verify the behavior

… issue-6843

Triggered by 30c35c6 on branch refs/heads/issue-6843

… issue-6843

Triggered by 95c7c50 on branch refs/heads/issue-6843

Copilot

Pull Request Overview

This PR migrates the legacy TreeEditor.Rank.Threshold remote preference into the new user‐preferences system.

Adds rankThreshold and rankThresholdDescription keys to localization dictionary
Defines a rankThreshold preference (with renderer) for multiple table types
Replaces old getPref usage with userPreferences.use in Tree.tsx
Introduces a new ThresholdRank renderer and related fetch logic

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
localization/preferences.ts	Added localization entries for rank threshold and its description
components/TreeView/Tree.tsx	Swapped `getPref` for `userPreferences.use` and removed import
components/Preferences/UserDefinitions.tsx	Inserted `rankThreshold` pref definitions across tables
components/Preferences/Renderers.tsx	Added `ThresholdRank` renderer and fetch helper
components/InitialContext/tests/snapshots/remotePrefs.test.ts.snap	Snapshot updated with unexpected key

Comments suppressed due to low confidence (2)

specifyweb/frontend/js_src/lib/localization/preferences.ts:131

Only en-us is provided for rankThreshold. Consider adding translations for other supported locales to ensure a complete localization.

  rankThreshold: {

specifyweb/frontend/js_src/lib/components/InitialContext/tests/snapshots/remotePrefs.test.ts.snap:53

The snapshot now includes TaxonTreeEditor.DisplayAuthor but no code change adds or fetches this key. Verify if this line should be removed or if the test/setup needs updating.

  "TaxonTreeEditor.DisplayAuthor": "true",

specifyweb/frontend/js_src/lib/components/Preferences/Renderers.tsx

specifyweb/frontend/js_src/lib/components/Preferences/UserDefinitions.tsx

…s.tsx Co-authored-by: Copilot <[email protected]>

This reverts commit e7c7afe.

… issue-6843

specifyweb/frontend/js_src/lib/components/Preferences/Renderers.tsx

CarolineDenis · 2025-07-01T12:36:51Z

The items in the rank list in the pref are not in the same order than in the trees. We might want to change that.
Feature works for me 👍

@CarolineDenis

Suggested by @CarolineDenis

grantfitzsimmons · 2025-07-01T16:41:10Z

The items in the rank list in the pref are not in the same order than in the trees. We might want to change that.

Fixed in the latest commit. Can you take another look?

Triggered by 86a8e33 on branch refs/heads/issue-6843

grantfitzsimmons · 2025-07-03T01:23:52Z

Using the API to grab all the ranks for the other trees (other than taxontreedefitem) returns all tree ranks from all disciplines–

http://localhost/api/specify/geographytreedefitem/

{
    "objects": [
        {
            "id": 1,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": false,
            "name": "Earth",
            "rankid": 0,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2018-11-09T12:00:27",
            "timestampmodified": "2018-11-09T12:00:27",
            "title": "Earth",
            "version": 1,
            "createdbyagent": null,
            "modifiedbyagent": null,
            "parent": null,
            "treedef": "/api/specify/geographytreedef/1/",
            "treeentries": "/api/specify/geography/?definitionitem=1",
            "children": "/api/specify/geographytreedefitem/?parent=1",
            "resource_uri": "/api/specify/geographytreedefitem/1/"
        },
        {
            "id": 2,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": false,
            "name": "Continent",
            "rankid": 100,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2018-11-09T12:00:27",
            "timestampmodified": "2018-11-09T12:00:27",
            "title": "Continent",
            "version": 0,
            "createdbyagent": null,
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/1/",
            "treedef": "/api/specify/geographytreedef/1/",
            "treeentries": "/api/specify/geography/?definitionitem=2",
            "children": "/api/specify/geographytreedefitem/?parent=2",
            "resource_uri": "/api/specify/geographytreedefitem/2/"
        },
        {
            "id": 3,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": false,
            "name": "Country",
            "rankid": 200,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2018-11-09T12:00:27",
            "timestampmodified": "2018-11-09T12:00:27",
            "title": "Country",
            "version": 0,
            "createdbyagent": null,
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/2/",
            "treedef": "/api/specify/geographytreedef/1/",
            "treeentries": "/api/specify/geography/?definitionitem=3",
            "children": "/api/specify/geographytreedefitem/?parent=3",
            "resource_uri": "/api/specify/geographytreedefitem/3/"
        },
        {
            "id": 4,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": true,
            "name": "State",
            "rankid": 300,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2018-11-09T12:00:27",
            "timestampmodified": "2018-11-09T12:00:27",
            "title": "State",
            "version": 0,
            "createdbyagent": null,
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/3/",
            "treedef": "/api/specify/geographytreedef/1/",
            "treeentries": "/api/specify/geography/?definitionitem=4",
            "children": "/api/specify/geographytreedefitem/?parent=4",
            "resource_uri": "/api/specify/geographytreedefitem/4/"
        },
        {
            "id": 5,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": true,
            "name": "County",
            "rankid": 400,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2018-11-09T12:00:27",
            "timestampmodified": "2018-11-09T12:00:27",
            "title": "County",
            "version": 0,
            "createdbyagent": null,
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/4/",
            "treedef": "/api/specify/geographytreedef/1/",
            "treeentries": "/api/specify/geography/?definitionitem=5",
            "children": "/api/specify/geographytreedefitem/?parent=5",
            "resource_uri": "/api/specify/geographytreedefitem/5/"
        },
        {
            "id": 6,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": false,
            "name": "Earth",
            "rankid": 0,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2019-04-01T15:10:44",
            "timestampmodified": "2019-04-01T15:10:44",
            "title": "Earth",
            "version": 1,
            "createdbyagent": "/api/specify/agent/1686/",
            "modifiedbyagent": null,
            "parent": null,
            "treedef": "/api/specify/geographytreedef/2/",
            "treeentries": "/api/specify/geography/?definitionitem=6",
            "children": "/api/specify/geographytreedefitem/?parent=6",
            "resource_uri": "/api/specify/geographytreedefitem/6/"
        },
        {
            "id": 7,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": false,
            "name": "Continent",
            "rankid": 100,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2019-04-01T15:10:44",
            "timestampmodified": "2019-04-01T15:10:44",
            "title": "Continent",
            "version": 0,
            "createdbyagent": "/api/specify/agent/1686/",
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/6/",
            "treedef": "/api/specify/geographytreedef/2/",
            "treeentries": "/api/specify/geography/?definitionitem=7",
            "children": "/api/specify/geographytreedefitem/?parent=7",
            "resource_uri": "/api/specify/geographytreedefitem/7/"
        },
        {
            "id": 8,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": true,
            "name": "Country",
            "rankid": 200,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2019-04-01T15:10:44",
            "timestampmodified": "2019-04-01T15:10:44",
            "title": "Country",
            "version": 0,
            "createdbyagent": "/api/specify/agent/1686/",
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/7/",
            "treedef": "/api/specify/geographytreedef/2/",
            "treeentries": "/api/specify/geography/?definitionitem=8",
            "children": "/api/specify/geographytreedefitem/?parent=8",
            "resource_uri": "/api/specify/geographytreedefitem/8/"
        },
        {
            "id": 9,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": true,
            "name": "State",
            "rankid": 300,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2019-04-01T15:10:44",
            "timestampmodified": "2019-04-01T15:10:44",
            "title": "State",
            "version": 0,
            "createdbyagent": "/api/specify/agent/1686/",
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/8/",
            "treedef": "/api/specify/geographytreedef/2/",
            "treeentries": "/api/specify/geography/?definitionitem=9",
            "children": "/api/specify/geographytreedefitem/?parent=9",
            "resource_uri": "/api/specify/geographytreedefitem/9/"
        },
        {
            "id": 10,
            "fullnameseparator": ", ",
            "isenforced": true,
            "isinfullname": true,
            "name": "County",
            "rankid": 400,
            "remarks": null,
            "textafter": null,
            "textbefore": null,
            "timestampcreated": "2019-04-01T15:10:44",
            "timestampmodified": "2019-04-01T15:10:44",
            "title": "County",
            "version": 0,
            "createdbyagent": "/api/specify/agent/1686/",
            "modifiedbyagent": null,
            "parent": "/api/specify/geographytreedefitem/9/",
            "treedef": "/api/specify/geographytreedef/2/",
            "treeentries": "/api/specify/geography/?definitionitem=10",
            "children": "/api/specify/geographytreedefitem/?parent=10",
            "resource_uri": "/api/specify/geographytreedefitem/10/"
        }
    ],
    "meta": {
        "limit": 20,
        "offset": 0,
        "total_count": 10
    }
}

Triggered by 5d91e20 on branch refs/heads/issue-6843

grantfitzsimmons added 3 commits June 30, 2025 20:56

Add renderer for taxon tree def items

5dea652

Add threshold rank preference

444b04f

Update preferences.ts

3c25958

github-project-automation bot added this to General Tester Board Jul 1, 2025

github-project-automation bot moved this to 📋Back Log in General Tester Board Jul 1, 2025

grantfitzsimmons changed the base branch from main to issue-6841 July 1, 2025 01:58

grantfitzsimmons added 12 commits June 30, 2025 21:00

Merge branch 'issue-6841' into issue-6843

c6e17cc

Update Renderers.tsx

cc2fbe6

Merge branch 'issue-6843' of https://github.com/specify/specify7 into…

4bb52d5

… issue-6843

Update remotePrefs.test.ts.snap

2ae8497

Update renderer to be generic across tree tables

8806806

Use user preference instead of remotePref

c760d44

Remove unused imports

25217bf

Update Renderers.tsx

30c35c6

Lint code with ESLint and Prettier

e80d3b7

Triggered by 30c35c6 on branch refs/heads/issue-6843

Correct description

68a187d

Merge branch 'issue-6843' of https://github.com/specify/specify7 into…

95c7c50

… issue-6843

Lint code with ESLint and Prettier

d18394c

Triggered by 95c7c50 on branch refs/heads/issue-6843

grantfitzsimmons requested a review from Copilot July 1, 2025 03:57

Copilot AI reviewed Jul 1, 2025

View reviewed changes

grantfitzsimmons and others added 7 commits June 30, 2025 23:03

Remove unused function

539027d

Update specifyweb/frontend/js_src/lib/components/Preferences/Renderer…

430e743

…s.tsx Co-authored-by: Copilot <[email protected]>

Remove 'none' option

e7c7afe

Update preferences.ts

fa71563

Revert "Remove 'none' option"

bbd714b

This reverts commit e7c7afe.

Merge branch 'issue-6843' of https://github.com/specify/specify7 into…

f7357dd

… issue-6843

Update preferences.ts

098d361

grantfitzsimmons marked this pull request as ready for review July 1, 2025 04:14

Merge branch 'issue-6841' into issue-6843

74ff3cb

grantfitzsimmons requested a review from a team July 1, 2025 04:17

CarolineDenis reviewed Jul 1, 2025

View reviewed changes

specifyweb/frontend/js_src/lib/components/Preferences/Renderers.tsx Outdated Show resolved Hide resolved

grantfitzsimmons added 2 commits July 1, 2025 09:13

Use RA<>

48314b3

Suggested by @CarolineDenis

Order ranks

86a8e33

grantfitzsimmons requested a review from CarolineDenis July 1, 2025 16:41

Lint code with ESLint and Prettier

4f08ce2

Triggered by 86a8e33 on branch refs/heads/issue-6843

Base automatically changed from issue-6841 to main July 2, 2025 23:29

Merge branch 'main' into issue-6843

77bf41a

grantfitzsimmons marked this pull request as draft July 3, 2025 01:24

melton-jason added 2 commits July 7, 2025 15:46

Merge branch 'main' into issue-6843

5d91e20

Lint code with ESLint and Prettier

7a2eff4

Triggered by 5d91e20 on branch refs/heads/issue-6843

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate `Rank.Threshold` to User Preferences #6844

Migrate `Rank.Threshold` to User Preferences #6844

Uh oh!

grantfitzsimmons commented Jul 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarolineDenis commented Jul 1, 2025 •

edited

Loading

Uh oh!

grantfitzsimmons commented Jul 1, 2025

Uh oh!

grantfitzsimmons commented Jul 3, 2025

Uh oh!

Uh oh!

Migrate Rank.Threshold to User Preferences #6844

Are you sure you want to change the base?

Migrate Rank.Threshold to User Preferences #6844

Uh oh!

Conversation

grantfitzsimmons commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarolineDenis commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grantfitzsimmons commented Jul 1, 2025

Uh oh!

grantfitzsimmons commented Jul 3, 2025

Uh oh!

Uh oh!

Migrate `Rank.Threshold` to User Preferences #6844

Migrate `Rank.Threshold` to User Preferences #6844

grantfitzsimmons commented Jul 1, 2025 •

edited

Loading

CarolineDenis commented Jul 1, 2025 •

edited

Loading