Skip to content

Filter picklist in WB and QB #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Filter picklist in WB and QB #6936

merged 3 commits into from
Jul 8, 2025

Conversation

CarolineDenis
Copy link
Contributor

Fixes #6911

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

For queries:

  • Go to query builder
  • Click on Collection object type
  • Add 'Name'
  • Filter by 'Equal'
  • Click on picklist
  • Verify that you only see the types for your collection

For WB:

  • Create a data set with CO as the base table

  • Map COT -> Name

  • Save

  • Click on COT picklist

  • Verify that you only see the types for your collection

  • Verify the pick list in data entry is still correct

  • Verify another picklist

@CarolineDenis CarolineDenis added this to the 7.11.1 milestone Jul 7, 2025
@CarolineDenis CarolineDenis requested review from melton-jason and a team July 7, 2025 14:10
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jul 7, 2025
@CarolineDenis CarolineDenis requested a review from acwhite211 July 7, 2025 14:11
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that you only see the types for your collection

For WB:

  • Verify that you only see the types for your collection

  • Verify the pick list in data entry is still correct

  • Verify another picklist

Looks good, COT picklist is filtered by collection everywhere I checked

@emenslin emenslin requested a review from a team July 7, 2025 16:15
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Case sensitivity strikes yet again!

I (non-exhaustively) went through the usages of genericTables and some of the usages of tables where a user-provided table name was used and didn't see any other cases where case-sensitivity would cause a similar problem.

Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that you only see the types for your collection
  • Verify that you only see the types for your collection
  • Verify the pick list in data entry is still correct
  • Verify another picklist

Looks good - can only see the types for each collection!

@CarolineDenis CarolineDenis merged commit 710615b into main Jul 8, 2025
14 checks passed
@CarolineDenis CarolineDenis deleted the issue-6911 branch July 8, 2025 13:59
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

COT is not sorted by collection in queries and workbench
4 participants