Skip to content

Add dependency to 0006 to avoid order issue #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Add dependency to 0006 to avoid order issue #6941

merged 3 commits into from
Jul 9, 2025

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Jul 7, 2025

Fixes #6898

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally works, assuming we accept the risk users who have already ran the patches/0006 migration would need to resolve the migration manually.
The impact might be very high: this might affect Specify 6, Specify 7, as well as any tools that use the Specify 7 API (#6888 (review)).
The subset of users this would affect would hopefully be small: internal and any who have pulled from main (or a branch derived of main) since #6384 was merged (June 24, 2025).

Ideally, I think this should be a separate migration altogether (which has dependencies on both patches/0006 and specify/0035) so that even if someone did pull from main since #6384, they would encounter no problems and don't have to manually resolve the version issue in the database.

Given that the risk that a user has pulled main may be sufficiently small (not included in a release, and within main slightly over 2 weeks), this approach is practically probably fine 🤞

@CarolineDenis CarolineDenis merged commit 4034117 into main Jul 9, 2025
14 checks passed
@CarolineDenis CarolineDenis deleted the issue-6898 branch July 9, 2025 17:56
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix migration issue
2 participants