Skip to content

Add container_name to each Docker service #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Add container_name to each Docker service #7028

merged 3 commits into from
Jul 14, 2025

Conversation

grantfitzsimmons
Copy link
Member

@grantfitzsimmons grantfitzsimmons commented Jul 11, 2025

Fixes #7027

Also removes the version attribute as we've been seeing this for years now:

WARN[0000] /specify7/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 

Requires little testing, but a developer or two checking this would be appreciated.

Testing instructions

  • Run docker compose up
  • See that all containers use the container_name set for each service after running docker ps

@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review July 11, 2025 16:06
@grantfitzsimmons grantfitzsimmons requested a review from Copilot July 11, 2025 16:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated Compose version attribute and adds explicit container_name entries to each Docker service for clearer container identification.

  • Removed the obsolete version key from the Compose file
  • Added container_name to every service for consistent naming
Comments suppressed due to low confidence (1)

docker-compose.yml:69

  • The container_name "worker" for the specify7-worker service is too generic and inconsistent with the service name. Consider renaming it to "specify7-worker" to match the service and prevent potential container name collisions.
    container_name: worker

@grantfitzsimmons grantfitzsimmons merged commit 9006d55 into main Jul 14, 2025
14 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-7027 branch July 14, 2025 15:24
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve development deployment service naming
2 participants