Skip to content

Remove components from v7.11.0 #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: v7110-hotfix
Choose a base branch
from
Open

Conversation

melton-jason
Copy link
Contributor

Fixes #7022

An answer to #6721 (comment), this PR essentially removes and disables the CollectionObject -> components and CollectionObject -> componentParent relationships.
Particularly, this PR:

  • Removes the relationships from the SchemaConfig
  • Removes the relationships from the DataModel viewer, uniqueness rules, and app resource visual editors
  • Removes the default Component form definitions
  • Removes the relationships from the DataModel
  • Will throw an error if the relationships are used in the form definitions

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to the CollectionObejct table in the Schema Config
  • Ensure the components and componentParent relationships are not present
  • Go to App Resources and find a View Set (i.e., View Definitions)
  • Go to the CollectionObject views
  • Click on Create
  • Ensure that there are no Component view definitions that can be copied from the defaults
  • Go to a CollectionObject View in a View Set
  • Attempt to add component and componentParent to the view definition (templates provided below)
    <row>
      <cell type="field" id="compParent" name="componentParent" uitype="querycbx"/>
    </row>
    <row>
      <cell type="subview" name="components" id="comps"/>
    </row>
  • For each relationship, ensure an error is thrown stating unknown field
  • Go a Record formatters App Resource
  • Ensure that the components and componentParent relationships can not be added to a CollectionObject table format

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ensure the components and componentParent relationships are not present
  • Ensure that there are no Component view definitions that can be copied from the defaults
  • For each relationship, ensure an error is thrown stating unknown field
  • Ensure that the components and componentParent relationships can not be added to a CollectionObject table format

Looks good, components were removed from everything!

@emenslin emenslin requested a review from a team July 11, 2025 16:42
@CarolineDenis CarolineDenis linked an issue Jul 11, 2025 that may be closed by this pull request
@melton-jason
Copy link
Contributor Author

This has been tagged and released! Thank you for your testing 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Erase CO component relationship
3 participants