Skip to content

Avoid error deleting selectseries field if it doesn't exist #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

acwhite211
Copy link
Member

@acwhite211 acwhite211 commented Jul 16, 2025

Fixes #7098
Fixes #6942

Avoid issues on the test panel with the 0036_remove_spquery_selectseries migration due to the database state being off when it comes to the the selectseries field being present in the spquery table.

This was addressed for #7020, but needs to be done in a timely manner in the main branch.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • For dev testers, run all the migrations, through 0036_remove_spquery_selectseries . Make sure they run without error.
  • For UX testing, open the QB viewer on the spquery table, and make sure that the "Select Series" field does not appear.

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jul 16, 2025
@acwhite211 acwhite211 requested review from grantfitzsimmons, CarolineDenis and a team July 16, 2025 19:47
@acwhite211 acwhite211 added this to the 7.11.1 milestone Jul 16, 2025
@acwhite211 acwhite211 self-assigned this Jul 16, 2025
@acwhite211 acwhite211 requested a review from a team July 16, 2025 19:53
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For UX testing, open the QB viewer on the spquery table, and make sure that the "Select Series" field does not appear.

Looks good

@emenslin emenslin requested a review from a team July 16, 2025 20:30
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For dev testers, run all the migrations, through 0036_remove_spquery_selectseries . Make sure they run without error.
  • For UX testing, open the QB viewer on the spquery table, and make sure that the "Select Series" field does not appear.

@grantfitzsimmons grantfitzsimmons requested a review from a team July 17, 2025 04:00
@CarolineDenis CarolineDenis merged commit 8c6b55c into main Jul 17, 2025
14 checks passed
@CarolineDenis CarolineDenis deleted the issue-7098 branch July 17, 2025 12:22
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can't DROP COLUMN SelectSeries, migration failing Issue with 0036_remove_spquery_selectseries migration
4 participants