Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add region class and tests #393

Open
wants to merge 3 commits into
base: v3-dev
Choose a base branch
from
Open

add region class and tests #393

wants to merge 3 commits into from

Conversation

KatKatKateryna
Copy link
Member

@KatKatKateryna KatKatKateryna commented Mar 12, 2025

Description & motivation

Replicate C# Region class: specklesystems/speckle-sharp-sdk#241

"New Region class is a flat geometry represented by the boundary curve and inner loop curves, which hostApp turns into a planar filled geometry (or, Region). Hatch ("region" with a pattern or gradient fill) is a type of new Region class with a property "hasHatchPattern=true".

Currently the displayValue is a list of Meshes (for the apps that can triangulate meshes). We hope that in the future the Viewer can support this geometry and create a fill in the Viewer, without the need to generate and send an extra Mesh."

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant