Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (parallel) netcdf file writer #10

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Conversation

apatlpo
Copy link
Contributor

@apatlpo apatlpo commented Jan 31, 2018

Simple implementation of a parallel netcdf file writer.
Suggestions for improvements are found at #9

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #10 into master will decrease coverage by 1.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   83.26%   82.14%   -1.13%     
==========================================
  Files          25       26       +1     
  Lines        4172     4229      +57     
==========================================
  Hits         3474     3474              
- Misses        698      755      +57
Impacted Files Coverage Δ
shenfun/utilities/nc_writer.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc2369...94c2b7c. Read the comment docs.

@mikaem
Copy link
Member

mikaem commented Jan 31, 2018

Codecov is reminding us that we should add a test for this file as well. Keeping that in mind I merge the PR:-)

@mikaem mikaem merged commit 466d714 into spectralDNS:master Jan 31, 2018
mikaem added a commit that referenced this pull request Jul 22, 2020
Add (parallel) netcdf file writer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants