support XOR-based bit mixing in heavy_hash for header_version 2 and misc#16
Open
x100111010 wants to merge 19 commits into
Open
support XOR-based bit mixing in heavy_hash for header_version 2 and misc#16x100111010 wants to merge 19 commits into
x100111010 wants to merge 19 commits into
Conversation
* also bumped the minimum dependency version of spectrex
…for header v2 - also remove sysinfo
has been renamed in rusty to `--enable-unsynced-mining`, go-spectred used `--allow-submit-block-when-not-synced` which is deprecated
This was referenced Apr 25, 2025
Closed
- separate `calculate_spectrex_v1()` and `calculate_spectrex_v2()` - add a test case for `heavy_hash_v2` - add `header_version` in submit block log
protobuf doesn't have a native uint16 type
dc0f94f to
af2a79c
Compare
disable uninlined_format_args lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supports the upcoming proposed changes in spectre-project/rusty-spectre#41
In version 1 we just took the upper bits of calculated sums (using
sum >> 10).In version 2 we now use XOR operations between different parts of the sum (
(sum & 0xF) ^ ((sum >> 4) & 0xF) ^ ((sum >> 8) & 0xF)) which introduces much more randomness and variation in the output.