Autogen models in flow #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnemitz
reviewed
Jun 12, 2025
There was a problem hiding this comment.
Couple of comments, but looks good so far!
Looking into the pipeline issue, it looks like some of the generated models spit out any, which Biome doesn't like. We can either configure the generator to output unknown instead, or add an exception to Biome. I'm looking into option 1, but if it isn't simple we can do option 2.
mnemitz
reviewed
Jun 12, 2025
mnemitz
reviewed
Jun 12, 2025
TudorCRL
force-pushed
the
feature/autogen-for-flow
branch
2 times, most recently
from
78a7a30 to
81f451e
Compare
Co-authored-by: Matt Nemitz <[email protected]>
Co-authored-by: Matt Nemitz <[email protected]>
Co-authored-by: Matt Nemitz <[email protected]>
TudorCRL
force-pushed
the
feature/autogen-for-flow
branch
from
5eb5228 to
9126144
Compare
mnemitz
reviewed
Jun 27, 2025
| { | ||
| "name": "@speechmatics/flow-client-react", | ||
| "version": "0.2.1", | ||
| "version": "1.0.0-rc.6", |
There was a problem hiding this comment.
Suggested change
| "version": "1.0.0-rc.6", | |
| "version": "1.0.0, |
packages/flow-client/package.json
Outdated
| { | ||
| "name": "@speechmatics/flow-client", | ||
| "version": "0.2.2", | ||
| "version": "1.0.0-rc.6", |
There was a problem hiding this comment.
Suggested change
| "version": "1.0.0-rc.6", | |
| "version": "1.0.0", |
packages/flow-client/models/Info.ts
Outdated
| @@ -0,0 +1,6 @@ | |||
| interface Info { | |||
| reason: string; | |||
| message: string; | |||
There was a problem hiding this comment.
I think this string will still break the discriminator right?
mnemitz
reviewed
Jun 27, 2025
Co-authored-by: Matt Nemitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autogen models in flow