linkcheck: retain default do-not-follow for redirects #13467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9d6d6f. Conflicts: tests/test_builders/test_build_linkcheck.py
jayaddison
force-pushed
the
issue-13462/linkcheck-allowed-redirects-default-none
branch
from
5681792 to
d16e135
Compare
jayaddison
commented
Apr 4, 2025
| @@ -3655,6 +3656,10 @@ and which failures and redirects it ignores. | |||
| It can be useful to detect unexpected redirects when using | |||
| :option:`the fail-on-warnings mode <sphinx-build --fail-on-warning>`. | |||
|
|
|||
| To deny all redirects, configure an empty dictionary (the default). | |||
|
|
|||
| To follow all redirections, configure a value of :code-py:`None`. | |||
There was a problem hiding this comment.
Given recent bugreport #13462 about unconfigured linkcheck_allow_redirects reported as unexpectedly None during sphinx-build -b html ... builds: we should check that running sphinx-build -b linkcheck ... for an affected project yields the expected {} default.
This reverts commit d16e135.
Note: using a value of Ref: #13462 (comment) |
jayaddison
deleted the
issue-13462/linkcheck-allowed-redirects-default-none
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
From some recent notes I've made about this draft, the behaviour is:
linkcheck_allowed_redirects:{}: default warn and log redirects without following themlinkcheck_allowed_redirects:None: follow all redirects, do not warn about themlinkcheck_allowed_redirects:{...}: unmodifiedReferences
linkcheck_allowed_redirectsis non-empty #13439.