Skip to content

Fix flaky test_numfig_disabled_warn by ensuring fresh build #14107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

Fix flaky test_numfig_disabled_warn by ensuring fresh build #14107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb61292
Fix flaky test_numfig_disabled_warn by ensuring fresh build
kartben Nov 27, 2025
d962275
Merge branch 'master' into fix14104
AA-Turner Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sphinx/testing/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ def app_params(
pytest.fail(msg)
kwargs['srcdir'] = test_params['shared_result']
restore = shared_result.restore(test_params['shared_result'])
kwargs.update(restore)
if restore:
kwargs.update(restore)
else:
kwargs['freshenv'] = True

# ##### prepare Application params

Expand Down Expand Up @@ -193,10 +196,11 @@ def make_app(test_params: dict[str, Any]) -> Iterator[Callable[..., SphinxTestAp

def make(*args: Any, **kwargs: Any) -> SphinxTestApp:
status, warning = StringIO(), StringIO()
restored = 'status' in kwargs
kwargs.setdefault('status', status)
kwargs.setdefault('warning', warning)
app_: SphinxTestApp
if test_params['shared_result']:
if test_params['shared_result'] and restored:
app_ = SphinxTestAppWrapperForSkipBuilding(*args, **kwargs)
else:
app_ = SphinxTestApp(*args, **kwargs)
Expand Down
Loading