Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flatten function, endpoint, and tests #31

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Added flatten function, endpoint, and tests #31

merged 1 commit into from
Feb 10, 2025

Conversation

dpp
Copy link
Contributor

@dpp dpp commented Jan 28, 2025

💻 Description of Change(s) (w/ context)

Issue #6 -- added a function that will flatten an Item by returning all the gitoids the Item Contains:|| and, recursively
traversing the contained Items doing the same

🧠 Rationale Behind Change(s)

Some Artifacts (e.g., Debian) packages contain a couple of .tar archives that contain the substance
of artifacts.

When building a set of gitoids that are "contained" by an artifact, flattening the set so that the contents
of the .tar and other containing "thingies" allows for a complete view of the contents of an artifact.

📝 Test Plan

Added a test for flatten

📜 Documentation

Commented code

💣 Quality Control

(All items must be checked before a PR is merged)
Did you…

  • Mention an issue number in the PR title?
  • Update the version # in the build file?
  • Create new and/or update relevant existing tests?
  • Create or update relevant documentation and/or diagrams?
  • Comment your code?
  • Fix any stray verbose logging (removing, or moving to debug / trace level)?

Before Merging…

  • Make sure the Quality Control boxes are all ticked
  • Make sure any open comments or conversations on the PR are resolved

use std::{path::PathBuf, time::Instant};
let start = Instant::now();
let goat_rodeo_test_data: PathBuf = "../goatrodeo/res_for_big_tent/".into();
// punt test is the files don't exist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// punt test is the files don't exist
// punt this test if the files don't exist

@dpp dpp merged commit ca743e3 into main Feb 10, 2025
1 check passed
@dpp dpp deleted the flatten branch February 12, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants