-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved to Axum and async #33
Merged
+1,404
−1,610
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b940275
First bit of refactor of Big Tent to using async and the axum web fra…
dpp f2aa6aa
Implemented additional features... should be at parity with old version
dpp d6b7143
Addressed an issue with a nightly feature I was using and also starte…
dpp 94a81e9
Fixed performance issues using async bufreader. Fixed routing problems
dpp 5013723
Integrated the flatten API endpoint and functionality
dpp 908e301
Cleaned up some stuff based on PR comments/feedback
dpp e48bbd2
More typo, etc. cleanup
dpp 08faceb
More cleanup based on Aria's feedback
dpp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
use anyhow::{bail, Result}; | ||
use clap::Parser; | ||
use tokio::fs::File; | ||
use std::{ | ||
fs::File, | ||
io::Read, | ||
net::{SocketAddr, ToSocketAddrs}, | ||
path::{Path, PathBuf}, | ||
}; | ||
|
@@ -15,11 +14,11 @@ pub struct Args { | |
#[arg(short, long)] | ||
pub conf: Option<PathBuf>, | ||
|
||
/// Number of threads to allow for servicing. | ||
/// A small number if on spinning disks, larger | ||
/// for SSD | ||
#[arg(short, long)] | ||
pub threads: Option<u16>, | ||
// /// Number of threads to allow for servicing. | ||
// /// A small number if on spinning disks, larger | ||
// /// for SSD | ||
// #[arg(short, long)] | ||
// pub threads: Option<u16>, | ||
|
||
/// hostname to bind to | ||
#[arg(long)] | ||
|
@@ -48,24 +47,25 @@ pub struct Args { | |
} | ||
|
||
impl Args { | ||
pub fn read_conf_file(&self) -> Result<Table> { | ||
pub async fn read_conf_file(&self) -> Result<Table> { | ||
use tokio::io::AsyncReadExt; | ||
let mut conf_file = File::open(match &self.conf { | ||
Some(path) if path.exists() && path.is_file() => path, | ||
_ => { | ||
bail!("A configuration file must be supplied") | ||
} | ||
})?; | ||
}).await?; | ||
let mut contents = String::new(); | ||
conf_file.read_to_string(&mut contents)?; | ||
conf_file.read_to_string(&mut contents).await?; | ||
match contents.parse::<Table>() { | ||
Ok(v) => Ok(v), | ||
Err(e) => bail!("Must provide a valid toml file: {:?}", e), | ||
} | ||
} | ||
|
||
pub fn num_threads(&self) -> u16 { | ||
self.threads.unwrap_or(7) | ||
} | ||
// pub fn num_threads(&self) -> u16 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this no longer needed? Should it be removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
// self.threads.unwrap_or(7) | ||
// } | ||
|
||
pub fn conf_file(&self) -> Result<PathBuf> { | ||
match &self.conf { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments got dissociated from their target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed