Cleanup and function/struct access control #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther method moving around Signed-off-by: David Pollak <[email protected]>
aredridel
approved these changes
Feb 12, 2025
Comment on lines
+113
to
+116
| pub fn get_cluster_file_hash(&self) -> u64 { | ||
| self.cluster_file_hash | ||
| } | ||
|
|
There was a problem hiding this comment.
Does the indirection get us anything if we're not relying on the ABI?
There was a problem hiding this comment.
Part of it is my Java roots... getters everywhere!
Part of it is figuring out how to abstract the data structure. Big Tent is a library and at some point we'll have to
stabilize the API... having pub stuff on structs makes API evolution harder...
There was a problem hiding this comment.
Yeah, a little harder. My experience is that most evolutions of note reshape it in more fundamental ways anyway and it comes out in the wash. (And breaking isn't the worst thing, just have to plan and communicate it a bit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Description of Change(s) (w/ context)
Cleaned up some pub struct elements that needed to be private. Some other method moving around
Made route creation public
🧠 Rationale Behind Change(s)
Improving library ergonomics
📝 Test Plan
Passes existing tests