Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #37" #38

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Revert "Merge pull request #37" #38

merged 1 commit into from
Feb 12, 2025
+5 −17

Conversation

aredridel
Copy link
Contributor

@aredridel aredridel commented Feb 12, 2025 •
edited
Loading

Turns out a check is emitted from CI runs called merely "build" and github's UI was really feisty about exposing this fact.

@aredridel
Revert "Merge pull request #37 from spice-labs-inc/as/emit-check-in-C…
0583dc1 
…I-to-gate-releases"

This reverts commit 56142c9, reversing
changes made to 5217f3f.
@aredridel aredridel changed the title Revert "Merge pull request #37 from spice-labs-inc/as/emit-check-in-C… Revert "Merge pull request #37" Feb 12, 2025
@aredridel aredridel merged commit 3c30fde into main Feb 12, 2025
1 check passed
@aredridel aredridel deleted the as/revert-last branch February 12, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpp dpp dpp approved these changes

@earldouglas earldouglas Awaiting requested review from earldouglas

@dpletter dpletter Awaiting requested review from dpletter

@CJ-cmd-byte CJ-cmd-byte Awaiting requested review from CJ-cmd-byte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aredridel @dpp