Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intern hash strings to reduce memory pressure. Improved logging #54

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

dpp
Copy link
Contributor

@dpp dpp commented Feb 4, 2025

💻 Description of Change(s) (w/ context)

Intern strings for hashes and gitoids. This behavior was changed in a recent update and it turns out
that interning has a major benefit for collections of JARs that share a lot of classes.

Fixed logging in some cases where we actually expect failure (like trying to open an ISO that's not
really an ISO)

🧠 Rationale Behind Change(s)

Basic cleanup after the huge changes in the last PR

📝 Test Plan

Passes test

📜 Documentation

Added some ScalaDocs

💣 Quality Control

(All items must be checked before a PR is merged)
Did you…

  • Mention an issue number in the PR title?
  • Update the version # in the build file?
  • Create new and/or update relevant existing tests?
  • Create or update relevant documentation and/or diagrams?
  • Comment your code?
  • Fix any stray verbose logging (removing, or moving to debug / trace level)?

Before Merging…

  • Make sure the Quality Control boxes are all ticked
  • Make sure any open comments or conversations on the PR are resolved

@dpp dpp requested review from aredridel and earldouglas February 4, 2025 12:57
Signed-off-by: David Pollak <[email protected]>
Copy link
Contributor

@aredridel aredridel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. And since we never really want to free those in any meaningful way that'll work great

@dpp dpp merged commit 1c486cd into main Feb 4, 2025
2 checks passed
@dpp dpp deleted the cleanup branch February 12, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants