Intern hash strings to reduce memory pressure. Improved logging #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Description of Change(s) (w/ context)
Intern strings for hashes and gitoids. This behavior was changed in a recent update and it turns out
that interning has a major benefit for collections of JARs that share a lot of classes.
Fixed logging in some cases where we actually expect failure (like trying to open an ISO that's not
really an ISO)
🧠 Rationale Behind Change(s)
Basic cleanup after the huge changes in the last PR
📝 Test Plan
Passes test
📜 Documentation
Added some ScalaDocs
💣 Quality Control
(All items must be checked before a PR is merged)
Did you…
Before Merging…