Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the averaging code. Improved decompression #57

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

dpp
Copy link
Contributor

@dpp dpp commented Feb 5, 2025

💻 Description of Change(s) (w/ context)

Set the "start of processing" after 30 items are processed

Don't try to decompress certain types.

🧠 Rationale Behind Change(s)

Improve time estimation.

Don't try to decompress an APK that's an Android APK

📝 Test Plan

Passes existing tests

📜 Documentation

What documentation did you add or update?
Was the documentation appropriate for the scope of this change?

💣 Quality Control

(All items must be checked before a PR is merged)
Did you…

  • Mention an issue number in the PR title?
  • Update the version # in the build file?
  • Create new and/or update relevant existing tests?
  • Create or update relevant documentation and/or diagrams?
  • Comment your code?
  • Fix any stray verbose logging (removing, or moving to debug / trace level)?

Before Merging…

  • Make sure the Quality Control boxes are all ticked
  • Make sure any open comments or conversations on the PR are resolved

@dpp dpp requested review from aredridel and earldouglas February 5, 2025 00:02
Signed-off-by: David Pollak <[email protected]>
} catch {
case e: Exception =>
if (
/*true ||*/ (in.mimeType != "application/vnd.android.package-archive" && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging remnant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum Bool
{
    True,
    False,
    FileNotFound,
    CommentedOutTrue
};

@dpp dpp merged commit 3032efa into main Feb 5, 2025
2 checks passed
@dpp dpp deleted the small_dusting branch February 12, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants