Caught an issue if the props file can't be parsed #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Pollak <[email protected]>
earldouglas
approved these changes
Feb 7, 2025
earldouglas
reviewed
Feb 7, 2025
| @@ -157,7 +157,10 @@ case class MavenState( | |||
| val manifestString = | |||
| Helpers.slurpInputToString(manifest.asStream()) | |||
| val props = java.util.Properties() | |||
| props.load(manifest.asStream()) | |||
| // if this causes an exception, welp... | |||
| Try { | |||
There was a problem hiding this comment.
Would it be worth logging, or would there be nothing for the user to do anyway?
There was a problem hiding this comment.
Maybe... do we have a plan in the Ingestion pipeline to review Error and other anomalies?
aredridel
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Description of Change(s) (w/ context)
If the Maven manifest file, can't be parsed, ignore the parse error
🧠 Rationale Behind Change(s)
The parse error was causing the whole JAR to fail
📝 Test Plan
Runs existing tests
📜 Documentation
What documentation did you add or update?
Was the documentation appropriate for the scope of this change?
💣 Quality Control
(All items must be checked before a PR is merged)
Did you…
Before Merging…