Lots of little clean-up after running the code and seeing corner cases #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cease. Better logging for manifest parsing, Catch an out of memory error when trying to parse invalid bytecode Signed-off-by: David Pollak <[email protected]>
aredridel
approved these changes
Feb 10, 2025
| props.load(manifest.asStream()) | ||
| } catch { | ||
| case e: Exception => |
Co-authored-by: Aria Stewart <[email protected]>
earldouglas
reviewed
Feb 10, 2025
| @@ -178,6 +178,11 @@ object Helpers { | |||
|
|
|||
| val clz = cp.parse() | |||
| clz.getSourceFilePath() | |||
| } catch { | |||
| case e: OutOfMemoryError => | |||
| // if the classfile is corrupt, we may get an OOME, swallow it and just don't | |||
earldouglas
approved these changes
Feb 10, 2025
aredridel
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Description of Change(s) (w/ context)
Catch exceptions generated by Tika so processing an artifact does not cease if Tika can't determine mime type.
Better logging for manifest parsing.
Catch an out of memory error when trying to parse invalid bytecode
🧠 Rationale Behind Change(s)
Each of the above issues was causing a whole artifact to not be processed. Catching the exceptions/errors
and substituting a reasonable value and logging the issues seems to be a better approach
📝 Test Plan
Existing tests pass.
📜 Documentation
What documentation did you add or update?
Was the documentation appropriate for the scope of this change?
💣 Quality Control
(All items must be checked before a PR is merged)
Did you…
Before Merging…