Fix: failed to update IP address of egw #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 19 19
Lines 3170 3170
=======================================
Hits 2665 2665
Misses 392 392
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. |
bzsuni
approved these changes
Jan 25, 2024
Signed-off-by: lou-lan <[email protected]>
lou-lan
force-pushed
the
fix/update-egw
branch
from
d63a78c to
8811187
Compare
weizhoublue
added
release/bug
|
change label to release/bug for release note |
|
change the title to be more comprehensible for the user to find what fix he needs |
|
is there a dedicated E2E case for this bug ? but not just verified by manual way |
Yes, there is |
This is a bug in an unreleased version, so I choose none （before） |
lou-lan
added
bug
weizhoublue
approved these changes
Jan 26, 2024
|
head up, all PR must be signed. I merge it in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing with the cluster's IP pool, one should not include oneself.
Fix #1155
Fix #1158