Remove deprecated fields for v2beta1 APIs #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4549 +/- ##
==========================================
- Coverage 75.69% 75.25% -0.45%
==========================================
Files 56 56
Lines 6760 6760
==========================================
- Hits 5117 5087 -30
- Misses 1428 1462 +34
+ Partials 215 211 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
weizhoublue
reviewed
Jan 9, 2025
| // ChainCNIJsonData is used to configure the configuration of chain CNI. | ||
| // format in json. | ||
| // +kubebuilder:validation:Optional | ||
| ChainCNIJsonData []string `json:"chainCNIJsonData"` |
There was a problem hiding this comment.
这是 ChainCNIJsonData , 用于配置 chainCNI，customCNIConfig 是另外的字段
weizhoublue
reviewed
Jan 9, 2025
| // The RDMA resource name of the nic. the RDMA resource is often reported to kubelet by the | ||
| // k8s-rdma-shared-dev-plugin. when it is not empty and spiderpool podResourceInject feature | ||
| // is enabled, spiderpool can automatically inject it into the container's resources via webhook. | ||
| RdmaResourceName string `json:"rdmaResourceName"` |
weizhoublue
reviewed
Jan 9, 2025
| // The RDMA resource name of the nic. the RDMA resource is often reported to kubelet by the | ||
| // k8s-rdma-shared-dev-plugin. when it is not empty and spiderpool podResourceInject feature | ||
| // is enabled, spiderpool can automatically inject it into the container's resources via webhook. | ||
| RdmaResourceName string `json:"rdmaResourceName"` |
weizhoublue
reviewed
Jan 9, 2025
| // +kubebuilder:validation:Required | ||
| // The SR-IOV RDMA resource name of the SpiderMultusConfig. the SR-IOV RDMA resource is often | ||
| // reported to kubelet by the sriov-device-plugin. | ||
| ResourceName string `json:"resourceName"` |
weizhoublue
reviewed
Jan 9, 2025
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:deprecated:reason="This field is deprecated and will be removed in future versions." | ||
| // DEPRECATED, use RdmaIsolation flled instead. | ||
| EnableRdma bool `json:"enableRdma"` |
weizhoublue
reviewed
Jan 9, 2025
| // it ensures isolation of RDMA traffic from other workloads in the system by moving | ||
| // the associated RDMA interfaces of the provided network interface to the container's | ||
| // network namespace path. | ||
| RdmaIsolation bool `json:"rdmaIsolation"` |
weizhoublue
reviewed
Jan 9, 2025
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:default=false | ||
| // Enforces ib-sriov-cni to work with ib-kubernetes. | ||
| IbKubernetesEnabled *bool `json:"ibKubernetesEnabled,omitempty"` |
cyclinder
force-pushed
the
bump_apis
branch
2 times, most recently
from
301b2e6 to
02cb8d7
Compare
|
可以忽略 Auto Golang Lint And Unittest 错误，因为修改了 vendor |
cyclinder
force-pushed
the
bump_apis
branch
10 times, most recently
from
a3bfdf5 to
d632b07
Compare
|
Ignore Auto MarkDown Lint / Markdown Lint, #4560 Will fix it. |
cyclinder
changed the title
weizhoublue
reviewed
Jan 26, 2025
| // +kubebuilder:validation:Optional | ||
| // enable share rdma for macvlan | ||
| EnableRdma bool `json:"enableRdma"` |
weizhoublue
reviewed
Jan 26, 2025
| // +kubebuilder:validation:Optional | ||
| // enable share rdma for ipvlan | ||
| EnableRdma bool `json:"enableRdma"` |
|
CI |
Ignore Auto MarkDown Lint / Markdown Lint, #4560 Will fix it. |
weizhoublue
reviewed
Jan 26, 2025
| RdmaResourceName string `json:"rdmaResourceName"` | ||
| // The RDMA resource name of the nic. the RDMA resource is often reported to kubelet by the | ||
| // k8s-rdma-shared-dev-plugin. when it is not empty and spiderpool podResourceInject feature | ||
| // is enabled, spiderpool can automatically inject it into the container's resources via webhook. |
weizhoublue
reviewed
Jan 26, 2025
| // The RDMA resource name of the nic. the RDMA resource is often reported to kubelet by the | ||
| // k8s-rdma-shared-dev-plugin. when it is not empty and spiderpool podResourceInject feature | ||
| // is enabled, spiderpool can automatically inject it into the container's resources via webhook. | ||
| RdmaResourceName string `json:"rdmaResourceName,omitempty"` |
cyclinder
force-pushed
the
bump_apis
branch
2 times, most recently
from
a2ba24a to
d177e3b
Compare
Signed-off-by: Cyclinder Kuo <[email protected]>
5 tasks
weizhoublue
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer:
As a part of #4301