fix(registry/auth): auth validation workaround#2225
Closed
radu-matei wants to merge 1 commit intospinframework:mainfrom
Closed
fix(registry/auth): auth validation workaround#2225radu-matei wants to merge 1 commit intospinframework:mainfrom
radu-matei wants to merge 1 commit intospinframework:mainfrom
Conversation
This commit updates the registry login logic to not error if the credential validation fails, but log the message and attempt to continue. This behavior unblocks the use of registries whose login flow does not accept certain auth types, but if the credentials entered are wrong, could lead to users being appearing to be logged in, but unable to access the registry without logging in again with the right credentials. Specifically, this most likely needs a --skip-validation flag to be explicitly passed by the user when logging in, but we probably need to rethink the login (and potentially add a logout / retry) flow. We should most likely not merge this commit in its current state, its goal is to immediately unblock a current use case, but posted for future reference. Signed-off-by: Radu Matei <radu@fermyon.com>
Contributor
|
We've decided to pursue #2308 as an alternate fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the registry login logic to not error if the credential validation fails, but log the message and attempt to continue.
This behavior unblocks the use of registries whose login flow does not accept certain auth types, but if the credentials entered are wrong, could lead to users being appearing to be logged in, but unable to access the registry without logging in again with the right credentials.
Specifically, this most likely needs a --skip-validation flag to be explicitly passed by the user when logging in, but we probably need to rethink the login (and potentially add a logout / retry) flow.
We should most likely not merge this commit in its current state, its goal is to immediately unblock a current use case, but posted for future reference.