fix: Should fix the deletion of permissions when resource name is uppercase #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercase After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase.
ovidiupopa07
force-pushed
the
fix/fix-permission-update-when-resource-name-uppercase
branch
from
323f5f0 to
ac55c7e
Compare
jasonmcintosh
approved these changes
Feb 7, 2023
|
@Mergifyio backport release-1.28.x release-1.29.x release-1.27.x |
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
…ercase (#1012) After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase. (cherry picked from commit 6d4bcfc) # Conflicts: # fiat-sql/src/test/kotlin/com/netflix/spinnaker/fiat/permissions/SqlPermissionsRepositoryTests.kt
✅ Backports have been created
|
link108
pushed a commit
that referenced
this pull request
Feb 7, 2023
…ercase (backport #1012) (#1013) Co-authored-by: ovidiupopa07 <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Feb 7, 2023
…ercase (#1012) (#1014) After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase. (cherry picked from commit 6d4bcfc) Co-authored-by: ovidiupopa07 <[email protected]>
jasonmcintosh
deleted the
fix/fix-permission-update-when-resource-name-uppercase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the update to make all resource names lowercase, the user role sync process deletes the permission if the resource name (provided by the ResourceProvider) is in uppercase and the one in DB is in lowercase.