Get signed file URL endpoint proposal #49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this compliant with Cloudflare workers' TOS? or notion's for that matter. |
|
Hm, that's a really good question. It's probably not compliant with Notion's TOS in the same way that probably none of Splitbee's unofficial Notion API is compliant haha As for Cloudflare workers, I'm not sure? The code makes a call to Notion's API and gets a signed URL to get a file from Notion's storage — if it's against TOS then maybe getting images from Notion's API would already be against TOS? |
… based on View; previously it just got the first item in the collection, which wouldn’t work with linked database views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I thought it would be pretty useful to have an endpoint to get signed file URLs for things like PDFs uploaded to Notion.
Here's an example request: https://notion-cloudflare-worker.yawnxyz.workers.dev/v1/asset?url=https://s3-us-west-2.amazonaws.com/secure.notion-static.com/7b07bcc5-c445-4646-92e7-80778396bf0f/fmicb-11-00397_(1).pdf&blockId=6cc938f5-76fc-4069-8315-d776778afc71