Skip to content

Send additional headers with Delete Requests. #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Send additional headers with Delete Requests. #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e12fab
Send additional headers with a delete request. Currently only GET, PO…
Oz4P4X3 Dec 2, 2019
20e7fa9
Merge remote-tracking branch 'upstream/master' into develop
Oz4P4X3 Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions splunklib/binding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ def connect(self):

@_authentication
@_log_duration
def delete(self, path_segment, owner=None, app=None, sharing=None, **query):
def delete(self, path_segment, owner=None, app=None, headers=None, sharing=None, **query):
"""Performs a DELETE operation at the REST path segment with the given
namespace and query.

Expand All @@ -589,6 +589,8 @@ def delete(self, path_segment, owner=None, app=None, sharing=None, **query):
:type owner: ``string``
:param app: The app context of the namespace (optional).
:type app: ``string``
:param headers: List of extra HTTP headers to send (optional).
:type headers: ``list`` of 2-tuples.
:param sharing: The sharing mode of the namespace (optional).
:type sharing: ``string``
:param query: All other keyword arguments, which are used as query
Expand Down Expand Up @@ -616,10 +618,15 @@ def delete(self, path_segment, owner=None, app=None, sharing=None, **query):
c.logout()
c.delete('apps/local') # raises AuthenticationError
"""

if headers is None:
headers = []

path = self.authority + self._abspath(path_segment, owner=owner,
app=app, sharing=sharing)
logging.debug("DELETE request to %s (body: %s)", path, repr(query))
response = self.http.delete(path, self._auth_headers, **query)
all_headers = headers + self.additional_headers + self._auth_headers
response = self.http.delete(path, all_headers, **query)
return response

@_authentication
Expand Down