Skip to content

UnicodeDecodeError caught for json_loads #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

UnicodeDecodeError caught for json_loads #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion splunklib/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,12 @@ def _parse_results(self, stream):
for line in stream.readlines():
strip_line = line.strip()
if strip_line.__len__() == 0: continue
parsed_line = json_loads(strip_line)
try:
parsed_line = json_loads(strip_line)
except UnicodeDecodeError:
# If UnicodeDecodeError is encountered, ignoring decode errors should ensure the
# line can be loaded; may be beneficial to raise a warning at this point.
parsed_line = json_loads(strip_line.decode(encoding="utf-8", errors="ignore"))
if "preview" in parsed_line:
self.is_preview = parsed_line["preview"]
if "messages" in parsed_line and parsed_line["messages"].__len__() > 0:
Expand Down